Handle event.redacts being None.

matrix-org · Oct 2, 2020 · cfb32b2 · cfb32b2
1 parent e3debf9
commit cfb32b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/8457.bugfix b/changelog.d/8457.bugfix
@@ -0,0 +1 @@
+Fix a bug where backfilling a room with an event that was missing the `redacts` field would break.
diff --git a/synapse/event_auth.py b/synapse/event_auth.py
@@ -446,7 +446,9 @@ def check_redaction(
 
     if room_version_obj.event_format == EventFormatVersions.V1:
         redacter_domain = get_domain_from_id(event.event_id)
-        redactee_domain = get_domain_from_id(event.redacts)
+        redactee_domain = None
+        if event.redacts:
+            redactee_domain = get_domain_from_id(event.redacts)
         if redacter_domain == redactee_domain:
             return True
     else:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a bug where backfilling a room with an event that was missing the `redacts` field would break.