Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

sample doc in #11561 is malformatted #11741

Closed
richvdh opened this issue Jan 13, 2022 · 1 comment · Fixed by #11749 or #11757
Closed

sample doc in #11561 is malformatted #11741

richvdh opened this issue Jan 13, 2022 · 1 comment · Fixed by #11749 or #11757
Assignees
@jaywink
Labels
T-Other Questions, user support, anything else.

Comments

@richvdh
Copy link
Member

richvdh commented Jan 13, 2022

see #11561 (review)
@jaywink jaywink self-assigned this Jan 13, 2022
@H-Shay H-Shay added the T-Other Questions, user support, anything else. label Jan 13, 2022
jaywink added a commit that referenced this issue Jan 14, 2022
@jaywink
Fix sample_config.yaml in regards track_puppeted_user_ips
4637d65 
Closes #11741

Signed-off-by: Jason Robinson <jasonr@matrix.org>
@jaywink jaywink mentioned this issue Jan 14, 2022
Merged
DMRobertson pushed a commit that referenced this issue Jan 14, 2022
@jaywink
Fix sample_config.yaml in regards track_puppeted_user_ips (#11749)
904bb04 
* Fix sample_config.yaml in regards track_puppeted_user_ips

Closes #11741

Signed-off-by: Jason Robinson <jasonr@matrix.org>
@richvdh richvdh reopened this Jan 14, 2022
@richvdh
Copy link
Member Author

richvdh commented Jan 14, 2022

please can we replace "If this is enabled" with "If track_puppeted_user_ips is set to true"?

also, what exactly does "both requests are tracked" mean? what are the "requests" in this context, and why are there two of them?

Sorry to nit-pick on this, but clear documentation for this file is really important.

@richvdh richvdh mentioned this issue Jan 15, 2022
Merged
richvdh added a commit that referenced this issue Jan 17, 2022
@richvdh
Fix up docs for track_puppeted_user_ips (again) (#11757)
86615aa 
Fixes #11741
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaywink jaywink

Labels
T-Other Questions, user support, anything else.
Projects
None yet
Milestone
No milestone
3 participants
@jaywink @richvdh @H-Shay