Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add tests for or prevent non-member events in state_events_at_start in MSC2716 batch sending #12110

Closed
tulir opened this issue Mar 1, 2022 · 1 comment
Closed

Add tests for or prevent non-member events in state_events_at_start in MSC2716 batch sending #12110

tulir opened this issue Mar 1, 2022 · 1 comment
Assignees
@MadLittleMods
Labels
A-Testing Issues related to testing in complement, synapse, etc T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@tulir
Copy link
Member

tulir commented Mar 1, 2022

Synapse 1.53 broke this branch of batch sending: https://github.com/matrix-org/synapse/blob/v1.53.0/synapse/handlers/room_batch.py#L232-L253

#12083 seems to somehow fix it, but the feature should get some tests or be removed entirely.
@tulir tulir mentioned this issue Mar 1, 2022
Merged
4 tasks
@MadLittleMods MadLittleMods added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-testing labels Mar 1, 2022
@MadLittleMods MadLittleMods self-assigned this Mar 26, 2022
MadLittleMods added a commit to matrix-org/complement that referenced this issue Mar 30, 2022
@MadLittleMods
Add test for non-member state events in /batch_send state_events_at_s…
bcb6d9f 
…tart

Tests for matrix-org/synapse#12110
@MadLittleMods MadLittleMods mentioned this issue Mar 30, 2022
Merged
MadLittleMods added a commit that referenced this issue Mar 30, 2022
@MadLittleMods
Allow non-member state sent in room batch to resolve for historic events
1d770c5 
Part of #12110

Complement test: matrix-org/complement#354

Previously, they didn't resolve because async `filter_events_for_client`
removes all outlier state except for out-of-band membership.
@MadLittleMods MadLittleMods mentioned this issue Mar 30, 2022
Merged
4 tasks
MadLittleMods added a commit that referenced this issue Apr 4, 2022
@MadLittleMods
Allow non-member state sent in room batch to resolve for historic eve…
9633eb2 
…nts (MSC2716) (#12329)

Part of #12110

Complement test: matrix-org/complement#354

Previously, they didn't resolve because async `filter_events_for_client`
removes all outlier state except for out-of-band membership.

And fundamentally, we have the state at these events so they shouldn't be marked as outliers.
MadLittleMods added a commit to matrix-org/complement that referenced this issue Apr 4, 2022
@MadLittleMods
Add test for non-member state events in /batch_send `state_events_a…
2180cc5 
…t_start` (#354)

Tests for matrix-org/synapse#12110

Synapse change: matrix-org/synapse#12329
@MadLittleMods
Copy link
Contributor

Closing as #12329 was merged to fix this use case in Synapse and Complement tests added in matrix-org/complement#354

@richvdh richvdh added A-Testing Issues related to testing in complement, synapse, etc and removed z-testing labels Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MadLittleMods MadLittleMods

Labels
A-Testing Issues related to testing in complement, synapse, etc T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadLittleMods @richvdh @tulir