Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

rejected events become unrejected during partial state resync #13411

Closed
richvdh opened this issue Jul 28, 2022 · 0 comments · Fixed by #13413
Closed

rejected events become unrejected during partial state resync #13411

richvdh opened this issue Jul 28, 2022 · 0 comments · Fixed by #13413
Assignees
@richvdh
Labels
A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Milestone
Q3 2022: Faster j...

Comments

@richvdh
Copy link
Member

richvdh commented Jul 28, 2022

If an event which should be rejected is received while a faster-join is in progress, it is initially rejected correctly. However, it then gets un-rejected during the resync!
@richvdh richvdh self-assigned this Jul 28, 2022
@richvdh richvdh added A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 28, 2022
@richvdh richvdh mentioned this issue Jul 28, 2022
Merged
richvdh added a commit to matrix-org/complement that referenced this issue Jul 28, 2022
@richvdh
Faster joins: test that events stay rejected
43972a3 
Regression test for matrix-org/synapse#13411
@richvdh richvdh mentioned this issue Jul 28, 2022
Merged
richvdh added a commit to matrix-org/complement that referenced this issue Aug 1, 2022
@richvdh
Faster joins: test that events stay rejected (#430)
66bfb59 
Regression test for matrix-org/synapse#13411
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richvdh richvdh

Labels
A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
Q3 2022: Faster joins: fix major know...
Development

Successfully merging a pull request may close this issue.

Faster joins: fix rejected events becoming un-rejected during resync matrix-org/synapse
1 participant
@richvdh