Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Replace non-free recaptcha_ajax.js #1932

Closed
andrewshadura opened this issue Feb 21, 2017 · 8 comments · Fixed by #3677
Closed

Replace non-free recaptcha_ajax.js #1932

andrewshadura opened this issue Feb 21, 2017 · 8 comments · Fixed by #3677

Comments

@andrewshadura
Copy link
Contributor

andrewshadura commented Feb 21, 2017 •
edited
Loading

Synapse ships minified non-free JavaScript at synapse/static/client/register/js/recaptcha_ajax.js.
Please either dynamically load it from Google’s CDN on demand, or replace it by a free alternative.

This is not related to the issue #1561.
@APwhitehat
Copy link
Contributor

Hi @andrewshadura
I don't think this is an issue for the following reasons :

  • Google reCAPTCHA is a free service
  • The whole point of the static client is to be loaded directly instead from the web .
  • The REST version of the matrix client (which is the default ) loads the reCAPTCHA from CDN

anyway this would need confirmation from the owners .

@andrewshadura
Copy link
Contributor Author

The service may be provided at no cost, but the JavaScript (which is currently being served by synapse and hence is included in the source) is not free software and, I’m afraid, non-redistributable.

@andrewshadura
Copy link
Contributor Author

I understand your point about the static client, but I think you’re aware that the JavaScript I’m talking about isn’t stand-alone, and talks to Google servers when loaded.

@APwhitehat
Copy link
Contributor

Yes you are right ,
I guess this is an issue .

@APwhitehat
Copy link
Contributor

@andrewshadura I relooked into this.
My current findings is that the synapse/static/client/register/js/recaptcha_ajax.js is unused as far as new user registration is concerned.

@andrewshadura
Copy link
Contributor Author

It’s referred to from synapse/static/client/register/index.html and then in synapse/static/client/register/js/register.js.

@APwhitehat
Copy link
Contributor

APwhitehat commented Mar 24, 2017 •
edited
Loading

reRecaptcha.js also is being automatically retrieved from Google's CDN.
I able to register new user from the included Client with Recaptcha .
Recaptcha is probably being called from the definition in the Google CDN's js file .

Seems weird :/

APwhitehat added a commit to APwhitehat/synapse that referenced this issue Mar 24, 2017
@APwhitehat
s/Replace/Remove/ non-free recaptcha_ajax.js matrix-org#1932
f3c45b2 
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
@andrewshadura
Copy link
Contributor Author

No, if you just remove recaptcha_ajax.js, nothing is loaded from the CDN.
Also, why have you literally put s/Replace/Remove/ into the commit message?! I meant since you're not replacing but removing code, you shouldn't say you're replacing it.

@andrewshadura andrewshadura mentioned this issue Jun 7, 2018
Closed
This was referenced Aug 10, 2018
Closed
Merged
andrewshadura added a commit to andrewshadura/synapse that referenced this issue Aug 10, 2018
@andrewshadura
Use recaptcha_ajax.js directly from Google
c75b71a 
The script recaptcha_ajax.js contains minified non-free code which
we probably cannot redistribute. Since it talks to Google servers
anyway, it is better to just download it from Google directly instead
of shipping it.

This fixes matrix-org#1932.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use recaptcha_ajax.js directly from Google andrewshadura/synapse
2 participants
@andrewshadura @APwhitehat