Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

new_room_user_id should be optional on /shutdown_room so you can remove rooms without repointing users elsewhere #3761

Closed
ara4n opened this issue Aug 27, 2018 · 6 comments · Fixed by #7964
Closed

new_room_user_id should be optional on /shutdown_room so you can remove rooms without repointing users elsewhere #3761

ara4n opened this issue Aug 27, 2018 · 6 comments · Fixed by #7964
Labels
z-feature (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Aug 27, 2018

No description provided.

@neilisfragile neilisfragile added z-p2 (Deprecated Label) z-feature (Deprecated Label) labels Oct 5, 2018
@richvdh
Copy link
Member

richvdh commented Jul 24, 2020

this should be a trivial change now that #7613 has landed. @dklimpel any interest in picking it up?

@richvdh richvdh added the Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution label Jul 24, 2020
@dklimpel
Copy link
Contributor

dklimpel commented Jul 24, 2020 •
edited
Loading

@richvdh I can do it. But does this make sense? Does the old API still need to be adapted?
Anyone who would like this feature can use the new API. POST /_synapse/admin/v1/rooms/<room_id>/delete
In my opinion this issue can be closed.

@richvdh
Copy link
Member

richvdh commented Jul 25, 2020

@dklimpel is it possible to shutdown a room without running a purge on it?

@dklimpel
Copy link
Contributor

dklimpel commented Jul 26, 2020 •
edited
Loading

No, I'm afraid not, it is not possible to shutdown without purge. I thought it was not a use case.
An alternative would be to add an option for purge room or not for the new api. What would you prefer, modify shutdown api or delete api or both?

@richvdh
Copy link
Member

richvdh commented Jul 27, 2020

I think it probably makes more sense to modify the delete api.

@dklimpel
Copy link
Contributor

Ok. I'll put it on my to-do list and wait for merging #7953

@dklimpel dklimpel mentioned this issue Jul 27, 2020
Merged
4 tasks
anoadragon453 pushed a commit that referenced this issue Jul 28, 2020
@dklimpel
Add an option to disable purge in delete room admin API (#7964)
e866e3b 
Add option ```purge``` to ```POST /_synapse/admin/v1/rooms/<room_id>/delete```
Fixes: #3761

Signed-off-by: Dirk Klimpel dirk@klimpel.org
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
z-feature (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an option to disable purge in delete room admin API dklimpel/synapse_archive
4 participants
@neilisfragile @ara4n @richvdh @dklimpel