Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

transaction.origin and pdu.origin are redundant and we should remove them #3816

Open
richvdh opened this issue Sep 6, 2018 · 1 comment
Open

transaction.origin and pdu.origin are redundant and we should remove them #3816

richvdh opened this issue Sep 6, 2018 · 1 comment
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented Sep 6, 2018

both these fields in the server-server api are redundant. transaction.origin is implied by the name of the server you're connected to, while pdu.origin is implied by the domain of the event_id (at least until MSC1640 lands, and after that probably has no useful purpose anyway).

Their presence is a foot-gun for server implementors, and led directly to #3796 in synapse. We should remove them from the s2s spec, and make sure that synapse really really doesn't do anything with them
@neilisfragile neilisfragile added the z-p2 (Deprecated Label) label Oct 5, 2018
@richvdh richvdh mentioned this issue Jul 26, 2019
Merged
@richvdh richvdh mentioned this issue Oct 8, 2019
Closed
timokoesters added a commit to timokoesters/ruma that referenced this issue Aug 12, 2020
@timokoesters
Remove origin field from transactions and pdus
c9eb6b4 
See matrix-org/synapse#3816
timokoesters added a commit to timokoesters/ruma that referenced this issue Aug 12, 2020
@timokoesters
Remove origin field from transactions and pdus
deb9b01 
See matrix-org/synapse#3816
timokoesters added a commit to timokoesters/ruma that referenced this issue Aug 13, 2020
@timokoesters
Remove origin field from transactions and pdus
a9c83c6 
See matrix-org/synapse#3816
timokoesters added a commit to timokoesters/ruma that referenced this issue Aug 13, 2020
@timokoesters
Remove origin field from transactions and pdus
fffd963 
See matrix-org/synapse#3816
timokoesters added a commit to timokoesters/ruma that referenced this issue Sep 12, 2020
@timokoesters
Remove origin field from transactions and pdus
9f4c720 
See matrix-org/synapse#3816
@timokoesters timokoesters mentioned this issue Sep 16, 2020
Closed
jplatte added a commit to ruma/ruma that referenced this issue Sep 17, 2020
@jplatte @timokoesters
Remove origin field from transactions and pdus for #[feature = "unsta…
15e1a4b 
…ble-pre-spec"]

See matrix-org/synapse#3816

Co-authored-by: Timo <timo@koesters.xyz>
@turt2live turt2live mentioned this issue Mar 1, 2022
Open
@DMRobertson DMRobertson added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. and removed z-enhancement labels Aug 25, 2022
@turt2live turt2live mentioned this issue Apr 4, 2023
Merged
@richvdh
Copy link
Member Author

richvdh commented May 30, 2023

pdu.origin was removed from the spec in matrix-org/matrix-spec#998; however as of this writing it is still populated by synapse. It is not, as far as I know, referenced anywhere.

transaction.origin is still present in the spec (though matrix-org/matrix-spec#374) proposes to change this), and populated by synapse. Again, I don't think it is used anywhere.

@clokep clokep added A-Spec-Compliance places where synapse does not conform to the spec S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-p2 (Deprecated Label) labels May 30, 2023
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@neilisfragile @clokep @richvdh @hawkowl @erikjohnston @DMRobertson