Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

now LL is in CS 0.5, we should remove it from unstable-features in versions? #5528

Closed
ara4n opened this issue Jun 22, 2019 · 7 comments
Closed

now LL is in CS 0.5, we should remove it from unstable-features in versions? #5528

ara4n opened this issue Jun 22, 2019 · 7 comments
Labels
z-p2 (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Jun 22, 2019

No description provided.

@turt2live
Copy link
Member

reliant on element-hq/element-web#9966

@richvdh
Copy link
Member

richvdh commented Jun 24, 2019

reliant on element-hq/element-web#9966

does this mean that we can never remove it, for fear of breaking old versions of riot?

@turt2live
Copy link
Member

No, it means we should get our ducks in a row and fix riot, wait X number (where X is small) Riot release cycles, then remove it from synapse.

The correct answer would have been Riot being proactive on this.

@turt2live
Copy link
Member

ftr, Riot's fix landed today which means it should land in a release in ~2 weeks. I would recommend waiting ~8 weeks before removing it from Synapse, but I'm also not a release coordinator.

@neilisfragile
Copy link
Contributor

set a reminder 8 weeks from now

@neilisfragile neilisfragile added maintenance z-p2 (Deprecated Label) labels Jun 27, 2019
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 16, 2019
@turt2live
Check for r0.6.0 support in addition to unstable feature flags
eeb2c46 
To avoid the same problem that happened with lazy-loading (see matrix-org/synapse#5528).

Note that as of writing r0.6.0 is not yet released, however it is the next scheduled release of the client-server API.
@turt2live turt2live mentioned this issue Sep 16, 2019
Merged
@turt2live
Copy link
Member

keywords: lazy-loading lazy loading

@turt2live turt2live mentioned this issue Sep 17, 2019
Closed
@aaronraimist aaronraimist mentioned this issue Feb 8, 2020
Merged
4 tasks
richvdh pushed a commit that referenced this issue Feb 13, 2020
@aaronraimist
Remove m.lazy_load_members from unstable features since it is in CS r…
dc3f998 
…0.5.0 (#6877)

Fixes #5528
@richvdh
Copy link
Member

richvdh commented Feb 13, 2020

done by #6877.

@richvdh richvdh closed this as completed Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neilisfragile @turt2live @ara4n @richvdh