Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fetch signing-keys directly from servers before falling back to the trusted_key_servers #6086

Open
richvdh opened this issue Sep 23, 2019 · 1 comment
Open

Fetch signing-keys directly from servers before falling back to the trusted_key_servers #6086

richvdh opened this issue Sep 23, 2019 · 1 comment
Labels
A-Federation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@richvdh
Copy link
Member

richvdh commented Sep 23, 2019 •
edited
Loading

Currently we try fetching keys from the trusted_key_servers before asking the server itself. We should reverse this.
@richvdh richvdh changed the title Fetch signing-keys directly from servers before falling back to the trusted_key_server Fetch signing-keys directly from servers before falling back to the trusted_key_servers Sep 23, 2019
erikjohnston added a commit that referenced this issue Sep 25, 2019
@erikjohnston
Fetch keys directly before using trusted key servers
c9b7d97 
Fixes #6086.
@erikjohnston erikjohnston mentioned this issue Sep 25, 2019
Closed
@ara4n ara4n added the phase:1 label Sep 26, 2019
@jryans jryans added phase:2 and removed phase:1 labels Sep 30, 2019
@turt2live turt2live mentioned this issue May 21, 2020
Closed
@richvdh richvdh removed the phase:3 label Oct 1, 2020
@richvdh
Copy link
Member Author

richvdh commented Oct 8, 2020

#6110 explains why changing this may not be a great plan.

@DMRobertson DMRobertson added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. and removed z-enhancement labels Aug 25, 2022
@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Federation and removed z-p1 z-privacy-sprint (Deprecated Label) labels Sep 7, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch keys directly before using trusted key servers matrix-org/synapse
6 participants
@jryans @neilisfragile @ara4n @richvdh @erikjohnston @DMRobertson