-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
6d062d3
to
f370c32
Compare
c191072
to
0b68a54
Compare
Can you give us a commit range to review or something please? There are too many commits to figure out whats going on without some help :) |
Right, sorry, I assumed this review would come after the ones on the PRs this one is built on top of. A list of all commits specific to this PR can be seen here, and for maximum clarity this PR only changes the following files:
None of the other PRs edit these files, so the reviewer can review just the changes to these files, without worrying about whether they've been changed by this PR or another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments; it kinda needs #6102 to land before it gets a proper review.
pending merge of #6102 |
d9efe03
to
05463e4
Compare
#6102 has been merged; I've rebased the branch on develop so it doesn't pull any more commit than it should. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Paired with matrix-org/synapse#6140 Defines the Synapse CI jobs to run the tox environment added in matrix-org/synapse#6140
* commit '14504ad57': Add CI for synapse_port_db (#6140)
Paired with matrix-org/pipelines#9
This PR adds:
.buildkite/docker-compose.pyXX.pgXX.yaml
)as well as a new script named
.buildkite/scripts/test_synapse_port_db.sh
that:synapse_port_db
script to migrate the test sqlite database to the empty postgresql database (with coverage)Step
2
is done via a new script located atscripts-dev/update_database
.The test sqlite database is extracted from a SyTest run, so that it can be considered as an actual homeserver's database with actual data in it.