This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make synapse_port_db correctly create indexes #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so it doesn't need a homeserver object to run
This reverts commit dac8eb0.
This way we don't have to rely on devs thinking about updating the script each time a new store starts using background updates.
|
ftr I'm looking at adding CI to the |
|
Manually tested on a homeserver with a few users and everything seemed to work ok \o/ |
richvdh
previously requested changes
Oct 2, 2019
The StatsStore class hasn't been split because it's tied to a lot of code, including code outside of its own file (such as get_event()), and doesn't register any looping call, so it should be fine to leave it as is.
…db_background_updates
babolivier
force-pushed
the
babolivier/port_db_background_updates
branch
from
87d1de3 to
1eb0600
Compare
|
As requested by @richvdh, the commits about factoring out the background updates from the database code have been moved to a dedicated PR: #6178 - this means that the reviewer can ignore any change to the The commits shown here are the ones pulled by merging that PR's branch into the current branch, since the current PR (#6102) now depends on it. |
richvdh
previously requested changes
Oct 10, 2019
richvdh
approved these changes
Oct 23, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'c97ed64db': Make synapse_port_db correctly create indexes (#6102)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
synapse_port_dbcorrectly create indexes in the PostgreSQL database, by having it run the background updates on the database before migrating the data.To ensure we're migrating the right data, also block the port if the SQLite3 database still has pending or ongoing background updates.
Fixes #4877