-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Synapse Docker container doesn't start due to prometheus_client version 0.9.0 #8766
Comments
A quick fix here is to add the version constraints to |
While we're in the area, we may want to make sure that all the dependencies here are actually still used. |
Did anyone consider, I dunno, addressing the breaking changes in Synapse and upgrading to the latest version of prometheus client? |
@ddevault this was brought up in the linked PR: #8767 (comment) |
You should not institutionalize a habit of pinning your dependencies as a permanent solution. You should always be aiming to support the latest version of them, and ingrain this at a cultural level. You're in for a world of hurt if you don't. When you're 6 versions behind on something, and suddenly it matters very much that you be on the latest version, but you have punted for long enough that you've ballooned your work 10x in the middle of a crisis. |
Personally, I would not have even merged a pull request like #8767 unless the submitter outlined a plan for upgrading and justified the temporary version pinning approach. |
Acknowledged and agreed; we will not treat this as a permanent solution. There's some debt to unravel here, but we'll get there. |
This now breaks the archlinux package, since python-prometheus_client has updated to 0.9.0 so synapse won't start since its too new. Oddly when I downgrade prometheus_client to 0.8.0-2 it doesn't detect prometheus_client at all... still trying to figure that one out. |
I think this can be closed with the follow-up of #8831 filed. @anoadragon453 does that sound correct? |
@amalon Yep, I just broke my synapse install on Arch too. A simple hack to get up and running again until this is fixed upstream is to change |
Version v0.9.0 of the
prometheus_client
python module was just released, and now our docker containers fail with the following:We need to investigate why the docker container is installing a version of a module outside of what's specified in python_dependencies.py.Looks like this is due to us installing the library separately without consulting the version requirements:
synapse/docker/Dockerfile
Lines 34 to 46 in 3dc1871
Currently anyone that builds a Synapse container will be affected, but our release containers built earlier should be fine.
The text was updated successfully, but these errors were encountered: