Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Port the Password Auth Providers module interface to the new generic interface #10548

Commits on Aug 6, 2021

  1. Moved to using new callback registering style

    You now register logintype->callback rather than
    having check_auth and check_password as the two
    only possible functions.
    
    modules now must provide the login types they
    support when they register, instead of providing
    a function get_supported_login_types.
    
    The auth handler is initialised before the modules
    are loaded and so supported login types must be
    worked out later
    
    A load_legacy method wraps old-style modules so
    that they work with the new system
    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    0841865 View commit details
    Browse the repository at this point in the history
  2. Added tests for new and legacy modules

    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    58d87e9 View commit details
    Browse the repository at this point in the history
  3. Removed the old module style from sample_config

    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    accef11 View commit details
    Browse the repository at this point in the history
  4. Updated docs with information on new callbacks

    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    d84e47c View commit details
    Browse the repository at this point in the history
  5. Added porting instructions to the docs

    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    b198647 View commit details
    Browse the repository at this point in the history
  6. added changelog

    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    d7d89ce View commit details
    Browse the repository at this point in the history
  7. removed now unused ModuleApi object in auth handler

    Azrenbeth authored and Azrenbeth committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    1f87fbd View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Added error handling when calling callbacks

    Also renamed the callback types to the form
    of XYZ_CALLBACK
    Azrenbeth authored and Azrenbeth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    6ad6ccd View commit details
    Browse the repository at this point in the history
  2. auth checkers now MUST return tuple

    (could previously return either a string or a tuple)
    Azrenbeth authored and Azrenbeth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    efeb758 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Removed duplicated statement in the docs

    Azrenbeth authored and Azrenbeth committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    e6bfd49 View commit details
    Browse the repository at this point in the history
  2. Merged origin/develop into branch

    Azrenbeth authored and Azrenbeth committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    00c11c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Applied suggestions from code review:

    Reworded some stuff
    Added a docstring
    Added a newline in docs
    Added some spaces so string concatinate as expected
    Made mypy '# type: ignore' comments more selective
    Azrenbeth authored and Azrenbeth committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    3083565 View commit details
    Browse the repository at this point in the history
  2. Register login_type, fields, auth_checker all in one chunk

    Azrenbeth authored and Azrenbeth committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    4f18f1b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Applied suggestions from code review

    Azrenbeth authored and Azrenbeth committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    f4a8484 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Merge remote-tracking branch 'origin/develop' into azren/password_aut…

    …h_providers_to_new_module_system
    Azrenbeth authored and Azrenbeth committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e65d49e View commit details
    Browse the repository at this point in the history
  2. Reformat password_aut_providers docs and fix some small issues

    Azrenbeth authored and Azrenbeth committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    3c9b6c2 View commit details
    Browse the repository at this point in the history
  3. Run linters

    Azrenbeth authored and Azrenbeth committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e889594 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Apply suggestion from code review

    Azrenbeth authored and Azrenbeth committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    4ad1bd1 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/develop' into azren/password_aut…

    …h_providers_to_new_module_system
    Azrenbeth authored and Azrenbeth committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    8e6ebfb View commit details
    Browse the repository at this point in the history
  3. Run linters

    Azrenbeth authored and Azrenbeth committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    55eede5 View commit details
    Browse the repository at this point in the history
  4. Add link to spec

    Azrenbeth authored and Azrenbeth committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    01c65d7 View commit details
    Browse the repository at this point in the history
  5. Tweaks to documentation

    Azrenbeth authored and Azrenbeth committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    6fe825f View commit details
    Browse the repository at this point in the history
  6. Add typehints to auth.py

    Azrenbeth authored and Azrenbeth committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    86e9607 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Configuration menu
    Copy the full SHA
    fc72533 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e37f11 View commit details
    Browse the repository at this point in the history
  3. Incorporate review comment + cleanup

    The documentation mentions the username parameter of auth checkers as
    `user` even though the code doesn't, in order to make it clear this is
    the same value clients include in login requests as `user`.
    babolivier committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    1cd658a View commit details
    Browse the repository at this point in the history
  4. Standardise example values

    babolivier committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    73ff756 View commit details
    Browse the repository at this point in the history