Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix long-standing bug where ReadWriteLock could drop logging contexts #10993

Merged
merged 1 commit into from
Oct 8, 2021

Commits on Oct 5, 2021

  1. Fix long-standing bug where ReadWriteLock could drop logging contexts

    Use `PreserveLoggingContext()` to ensure that logging contexts are not
    lost when exiting a read/write lock.
    
    When exiting a read/write lock, callbacks on a `Deferred` are triggered
    as a signal to any waiting coroutines. Any waiting coroutine that
    becomes runnable is likely to follow the Synapse logging context rules
    and will restore its own logging context, then either run to completion
    or await another `Deferred`, resetting the logging context in the
    process.
    Sean Quah committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b6fc0c8 View commit details
    Browse the repository at this point in the history