Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

WIP: Enable email notification on SSO when set in the config #11805

Closed
wants to merge 2 commits into from
Closed

WIP: Enable email notification on SSO when set in the config #11805

wants to merge 2 commits into from

Conversation

lukasdenk
Copy link
Contributor

@lukasdenk lukasdenk commented Jan 24, 2022

Fixes #10882.

Fix a bug where email notifications were not enabled when the user logged in via an SSO even though in the config email.notif_for_new_users and email.enable_notifs were set to true.

Tested with keycloak.

Signed-off by: Lukas Denk, lukasdenk@web.de

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@lukasdenk lukasdenk requested a review from a team as a code owner January 24, 2022 09:42
@clokep
Copy link
Member

clokep commented Jan 24, 2022

Note that this essentially reverts #11770, which was a partial reversion of #11675. So I think there's more to this than just changing that if-statement. See #11769 for issues which occurred with this change.

@lukasdenk lukasdenk changed the title Enable email notification on SSO when set in the config WIP: Enable email notification on SSO when set in the config Jan 26, 2022
@lukasdenk
Copy link
Contributor Author

Set to WIP since the proposed solution causes the issues referenced to in #11769.

@clokep
Copy link
Member

clokep commented Jan 27, 2022

@lukasdenk From your point of view -- are you waiting on some feedback from the Synapse team or do you need to investigate more what's going on? I'm wondering if the review request accurately represents the current status!

@clokep clokep removed the request for review from a team January 28, 2022 12:28
@lukasdenk lukasdenk marked this pull request as draft January 31, 2022 14:30
@lukasdenk lukasdenk closed this Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email notifications are not automatically enabled when authenticating via SSO or using inhibit_login
2 participants