Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

synapse.api.auth.Auth cleanup: make permission-related methods use Requester instead of the UserID #13024

Merged
merged 14 commits into from
Aug 22, 2022
Merged

synapse.api.auth.Auth cleanup: make permission-related methods use Requester instead of the UserID #13024

merged 14 commits into from
Aug 22, 2022

Commits on Aug 5, 2022

  1. Pass the requester to assert_user_is_admin instead of the UserID 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5358b88 View commit details
    Browse the repository at this point in the history

  2. Make the permissions-related methods use the requester 

    instead of just the UserID

Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    68474ee View commit details
    Browse the repository at this point in the history

  3. Make Auth.get_user_by_access_token and _get_appservice_user return a … 

    …Requester

Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    6f2c0c3 View commit details
    Browse the repository at this point in the history

  4. Refactor get_user_by_req to keep the same logic for appservice user… 

    …s and regular ones

Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    7beb0a4 View commit details
    Browse the repository at this point in the history

  5. Newsfile. 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    c4bb34d View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Update the docstrings where the user_id param changed to the requester. 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    bcfa8d9 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    6e41a06 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Get rid of the mark_as_used parameter 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    1670733 View commit details
    Browse the repository at this point in the history

  2. Revert to using a dummy device ID for appservices user_ips recordings 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    f74ff1f View commit details
    Browse the repository at this point in the history

  3. Fix tests mocks & use the right method in guest registration 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    9f91f78 View commit details
    Browse the repository at this point in the history

  4. Appease the linter 

    Signed-off-by: Quentin Gliech <quenting@element.io>
    @sandhose
    sandhose committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2a926c6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into quenting/auth-api-cleanup/perm-requester

    @sandhose
    sandhose authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    f48a202 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Update synapse/api/auth.py

    @richvdh
    richvdh authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    7baca38 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into quenting/auth-api-cleanup/perm-requester

    @richvdh
    richvdh authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    1f3cceb View commit details
    Browse the repository at this point in the history