Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't require optional invite_room_state field on fed v2 invite #14083

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Oct 6, 2022

Fixes #10800.

The spec marks this field as optional; we no longer error if the field is absent.

@anoadragon453 anoadragon453 marked this pull request as ready for review October 12, 2022 13:40
@anoadragon453 anoadragon453 requested a review from a team as a code owner October 12, 2022 13:40
@reivilibre reivilibre self-requested a review October 14, 2022 10:18
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good; any thoughts on whether this should be tested (e.g. in complement?)

@anoadragon453
Copy link
Member Author

any thoughts on whether this should be tested (e.g. in complement?)

Yes, I think it should be as it is marked as an optional field in the spec, We'd want a port of this sytest, but with an additional variant that excludes invite_room_state from the request.

@anoadragon453 anoadragon453 merged commit 97b3d03 into develop Oct 14, 2022
@anoadragon453 anoadragon453 deleted the anoa/optional_room_state branch October 14, 2022 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invite_room_state is required by Synapse in /_matrix/federation/v2/invite/, contrary to spec
2 participants