Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove not needed replication listener in docker compose example #14107

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Oct 7, 2022

See: #14077 (comment)

I think the replication listener in #12737 is unnecessary. The list of federation senders is stored in WorkerConfig.federation_shard_config, and nothing seems to send out replication requests based off of it.

fyi: @Thumbscrew

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Signed-off-by: Dirk Klimpel dirk@klimpel.org

Comment on lines -97 to -105
### Add Workers to `instance_map`

Locate the `instance_map` section of your `homeserver.yaml` and populate it with your workers:

```yaml
instance_map:
synapse-generic-worker-1: # The worker_name setting in your worker configuration file
host: synapse-generic-worker-1 # The name of the worker service in your Docker Compose file
port: 8034 # The port assigned to the replication listener in your worker config file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An instance_map is only is required for stream writers.
See also:

elif worker_type == "event_persister":
# Event persisters write to the events stream, so we need to update
# the list of event stream writers
shared_config.setdefault("stream_writers", {}).setdefault("events", []).append(
worker_name
)
# Map of stream writer instance names to host/ports combos
instance_map[worker_name] = {
"host": "localhost",
"port": worker_port,
}

Stream writers are not part of this example and explanation and need some more configuration eg stream_writers.

@dklimpel dklimpel marked this pull request as ready for review October 7, 2022 20:28
@dklimpel dklimpel requested a review from a team as a code owner October 7, 2022 20:28
@erikjohnston erikjohnston merged commit 1eb8dcf into matrix-org:develop Oct 17, 2022
@dklimpel dklimpel deleted the fix_docker branch October 17, 2022 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants