Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix #12880 : notifications stop to work if last read event has been purged in a room #14441

Closed

Conversation

laurent-treeb
Copy link

@laurent-treeb laurent-treeb commented Nov 14, 2022

Fix #12880 : notifications stop to work if last read event has been purged in a room

Following this comment #12880 (comment) that explains where the bug is, i choose a third way to resolve by updating the "The second query gets all event_push_actions for rooms with no read receipts." by adding rooms that have a read receipt that pointing to purged event.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a merge conflict. Can you resolve it?

@clokep
Copy link
Member

clokep commented Nov 16, 2022

Also -- please update the title and description with a bit of information of what this PR accomplishes and how it does it.

@laurent-treeb laurent-treeb changed the title Fix #12880 Fix #12880 : notification stop to work if last read event has been purge in a room Nov 17, 2022
@laurent-treeb laurent-treeb changed the title Fix #12880 : notification stop to work if last read event has been purge in a room Fix #12880 : notifications stop to work if last read event has been purge in a room Nov 17, 2022
@laurent-treeb laurent-treeb changed the title Fix #12880 : notifications stop to work if last read event has been purge in a room Fix #12880 : notifications stop to work if last read event has been purged in a room Nov 17, 2022
@laurent-treeb
Copy link
Author

laurent-treeb commented Nov 17, 2022

This has a merge conflict. Can you resolve it?

Sorry no. A big merge has been done in 1.62 with this merge : #13005

So the PR may be helpfull for someone who wants to override a Synapse server before the 1.62. (I change the destination branch of the PR).

@laurent-treeb laurent-treeb changed the base branch from develop to release-v1.61 November 17, 2022 11:46
@clokep
Copy link
Member

clokep commented Jan 25, 2023

Closing as the author has stated they are not interested in continuing to work on this PR.

@clokep clokep closed this Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push notifications stop working when a history purge deletes the event a read receipt is pointing at
3 participants