Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update unit tests configuration settings #14568

Merged
merged 24 commits into from
Dec 1, 2022
Merged

Update unit tests configuration settings #14568

merged 24 commits into from
Dec 1, 2022

Commits on Nov 27, 2022

  1. Adjust tests with legacy settings for sending federation to use moder… 

    …n settings.
    @realtyem
    realtyem committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    a89ec04 View commit details
    Browse the repository at this point in the history

  2. Adjust tests with legacy settings involving pushers to modern settings.

    @realtyem
    realtyem committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    8e99103 View commit details
    Browse the repository at this point in the history

  3. Linting found a whoops.

    @realtyem
    realtyem committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    2b972a5 View commit details
    Browse the repository at this point in the history

  4. Add explicit override. 

    ...to disable the potential for pushing to be active on the fake main process. Is this accurate or unnecessary?
    @realtyem
    realtyem committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    0dafd0f View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Replace 'synapse.app.client_reader' with 'synapse.app.generic_worker'… 

    … and fix comments.
    @realtyem
    realtyem committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    eab6536 View commit details
    Browse the repository at this point in the history

  2. Update tests using 'update_user_directory'. 

    By setting 'update_user_directory_from_worker' to 'None', it disables the functionality(and I added that comment where the default config is written out). If you need to re-enable this functionality on master, either .pop() that value or alternatively set it to master which appears to work as well.
    @realtyem
    realtyem committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b57aeb1 View commit details
    Browse the repository at this point in the history

  3. Changelog

    @realtyem
    realtyem committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    44ec2eb View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Per review, update how 'update_user_directory_from_worker' is used to… 

    … be more clear(and accurate).
    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b00d88f View commit details
    Browse the repository at this point in the history

  2. Per review, consolidate overridden settings into a 'default_config()'… 

    … block. Add docstring to Test Class that explains it's turned on(check for accuracy generally).
    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    91195d3 View commit details
    Browse the repository at this point in the history

  3. Per review, consolidate override into a 'default_config()' and add do… 

    …cstring.
    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0abc6cc View commit details
    Browse the repository at this point in the history

  4. Remove now unused import

    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    c37364d View commit details
    Browse the repository at this point in the history

  5. Shorten a bunch of wordy comments.

    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b9f765d View commit details
    Browse the repository at this point in the history

  6. Per review, consolidate override into a 'default_config()' and add do… 

    …cstring.
    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    26c7bec View commit details
    Browse the repository at this point in the history

  7. Per review, remove redundant 'default_config()'s that served no purpo… 

    …se(see what I did there).
    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    e7138f2 View commit details
    Browse the repository at this point in the history

  8. Per review, change all 'sender's to 'federation_sender's.

    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    71623f0 View commit details
    Browse the repository at this point in the history

  9. Remove more unused imports.

    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    8bde002 View commit details
    Browse the repository at this point in the history

  10. Per review, fix up a bunch of things I did weird/wrong. And remove th… 

    …e 'default_config' block too.
    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    2c1a0a0 View commit details
    Browse the repository at this point in the history

  11. Update tests/replication/test_federation_ack.py 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @realtyem @clokep
    realtyem and clokep committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9cb0a6f View commit details
    Browse the repository at this point in the history

  12. Give the last worker a name.

    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b2e4590 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'develop' into fix-tests-generic-workers

    @realtyem
    realtyem committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a1a848f View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Remove outdated comment.

    @clokep
    clokep committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    6de8d5a View commit details
    Browse the repository at this point in the history

  2. Tweak comment / name of user dir worker.

    @clokep
    clokep committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    9ab160f View commit details
    Browse the repository at this point in the history

  3. Clarify changelog.

    @clokep
    clokep committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    62ff49e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into fix-tests-generic-workers

    @clokep
    clokep committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    b3025ad View commit details
    Browse the repository at this point in the history