-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adding a version picker for Synapse docs #16533
Conversation
Signed-off-by: Dmytro Kagirov <dmytro27kagirov@gmail.com>
Signed-off-by: Dmytro Kagirov <dmytro27kagirov@gmail.com>
Signed-off-by: Dmytro Kagirov <dmytro27kagirov@gmail.com>
@Dmytro27Ind Sorry that this hasn't been reviewed yet. We've recently fixed our ability to preview documentation for PRs, so if you could merge in develop then hopefully it'll be easier for us to review (as we'll be able to play around with the real thing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Needs updating)
Signed-off-by: Dmytro Kagirov <dmytro27kagirov@gmail.com>
@erikjohnston Hello. I have fixed the conflicts and also added v1.97. Now you can review it |
Signed-off-by: Dmytro Kagirov <dmytro27kagirov@gmail.com>
@erikjohnston It seems that PR Documentation Preview (https://pr16533--synapse-docs-previews.netlify.app/) only builds the current version of the documentation. You can see the verison picker, but if you change the version, you'll see the not found page: If you want to be able to play around with it, you can create a fork and build the documentation in your fork. PS v1.96, v1.97 and the latest versions don't work in my github pages documentation preview because I built it over a month ago on v1.95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for tackling this - this is something I've personally wanted to see added since we introduced the documentation website :)
A few small comments below, but on the whole lgtm.
Signed-off-by: Dmytro Kagirov <dmytro27kagirov@gmail.com>
Signed-off-by: Dmytro Kagirov <dmytro27kagirov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. This now looks good to me!
Merging, and will run the new GitHub action.
@anoadragon453 Hello. I checked it on https://matrix-org.github.io/synapse/develop/ and the version picker works well, but for the latest tag you have several choices:
P.S. to see the version picker, you need to switch from the latest tag to any tag in the url line. |
Hi @Dmytro27Ind, thanks for the run down! We'll (hopefully) be doing another release of Synapse tomorrow, so I think that'd be the easiest path forwards. Otherwise we'd need to cherry-pick 483d22a to Still, it looks excellent on the live version'd pages that are up now. Thank you for your work! |
🚀 Adding a version picker for Synapse docs
In this pull request I've added a version picker for the Synapse docs. The problem was that we need to add this version picker for all previous versions of the docs (not just develop). So in addition to adding a version picker, I also wrote a github action to add a version picker for all previous versions of the docs. This action "Add Version Picker (RUN ONCE)" needs to be run manually for develop branch and only once, because then the version picker will be in all versions of the docs and then we don't need to run this action anymore,
📋 Related Issues
This pull request is related to this issue: #15692, #11647
📝 Instructions
To properly add the version picker, follow these steps:
📷 Screenshots
As you can see this version picker, can handle all themes.
Pull Request Checklist
Signed-off-by: Dmytro Kagirov dmytro27kagirov@gmail.com