Remove some DNS lookups to support IPv6 #1934
Conversation
The current implementation only does a lookup for an A record. This is troublesome for IPv6-enabled or IPv6-only servers. Removing the lookup lets Twisted do the resolving. Signed-off-by: Silke Hofstra <silke@slxh.eu>
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Signed-off-by: Silke Hofstra <silke@slxh.eu>
|
Does this fix federations on dual-stack servers? |
|
@jython234: I'm not aware of significant problems with dual stack servers (other than Synapse not binding on |
|
This patch breaks connections to many hosts. The default config causes servers to only listen on IPv4 (see #1886), but Synapse will try to connect over IPv6 for domains with an AAAA-record, yielding many "Connection refused" messages. |
|
This is going to require us to properly retry different IP addresses when we get TCP level failures on connection, otherwise its (at the very least) going to cause delays as we back off the reconnects. Closing for now, but reopen if you manage to fix that :) |
The current implementation only does a lookup for an A record. This is troublesome for IPv6-enabled or IPv6-only servers. Removing the lookup lets Twisted do the resolving.
Note that the alternative (doing both A and AAAA lookups) is troublesome as this will break servers having only IPv4 or IPv6 connectivity unless the server's connectivity is also checked.