This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Avoid resetting state on rejected events #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/no_reset_state_on_rejections
branch
from
1dd0b83 to
3fd805e
Compare
|
If we have a rejected state event that attempts to replace an older state, do we still see that older state for subsequent events? |
A few non-functional changes: * A bunch of docstrings to document types * Split `EventsStore._persist_events_txn` up a bit. Hopefully it's a bit more readable. * Rephrase `EventFederationStore._update_min_depth_for_room_txn` to avoid mind-bending conditional. * Rephrase rejected/outlier conditional in `_update_outliers_txn` to avoid mind-bending conditional.
When we get a rejected event, give it the same state_group as its prev_event, rather than no state_group at all. This should fix #1935.
richvdh
force-pushed
the
rav/no_reset_state_on_rejections
branch
from
3fd805e to
0c01f82
Compare
yes. |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presented as two commits: one which is a bit of a refactorathon, but should amount to a no-op functionally speaking, and a second which actually makes the change.