Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Do a GC after each test to fix logcontext leaks #4227

Merged
merged 3 commits into from
Nov 27, 2018
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 26, 2018

This replaces an earlier attempt to fix these leaks on #4213.

This feels like an awful hack, but perhaps it's the least bad option

@richvdh richvdh requested a review from a team November 26, 2018 14:47
@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@e8690de). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4227   +/-   ##
==========================================
  Coverage           ?   66.65%           
==========================================
  Files              ?      299           
  Lines              ?    29796           
  Branches           ?     4871           
==========================================
  Hits               ?    19860           
  Misses             ?     8501           
  Partials           ?     1435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8690de...eb33f7f. Read the comment docs.

@hawkowl hawkowl merged commit de8772a into develop Nov 27, 2018
@hawkowl hawkowl deleted the rav/gc_after_test branch November 27, 2018 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants