This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
add more detail to logging regarding "More than one row matched" error #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4234 +/- ##
===========================================
- Coverage 73.55% 73.54% -0.01%
===========================================
Files 299 299
Lines 29806 29806
Branches 4872 4872
===========================================
- Hits 21923 21921 -2
+ Misses 6456 6454 -2
- Partials 1427 1431 +4
Continue to review full report at Codecov.
|
hawkowl
reviewed
Dec 3, 2018
synapse/storage/_base.py
Outdated
| @@ -849,9 +849,9 @@ def _simple_update_one_txn(cls, txn, table, keyvalues, updatevalues): | |||
| rowcount = cls._simple_update_txn(txn, table, keyvalues, updatevalues) | |||
|
|
|||
| if rowcount == 0: | |||
| raise StoreError(404, "No row found") | |||
| raise StoreError(404, "No row found (%s)" % table) | |||
There was a problem hiding this comment.
The syntax here should be "No row found (%s)" % (table,)
richvdh
approved these changes
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.