Drop sent_transactions

[aaronraimist]

Fixes #2930 (maybe, I have no idea what I'm doing 😅)

[codecov-io]

Codecov Report

Merging #4244 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4244      +/-   ##
===========================================
- Coverage    73.55%   73.54%   -0.01%     
===========================================
  Files          299      298       -1     
  Lines        29806    29796      -10     
  Branches      4872     4871       -1     
===========================================
- Hits         21923    21913      -10     
+ Misses        6456     6453       -3     
- Partials      1427     1430       +3

Impacted Files	Coverage Δ
synapse/storage/prepare_database.py	74.67% <100%> (ø)	⬆️
synapse/util/file_consumer.py	80.7% <0%> (-1.76%)	⬇️
synapse/handlers/search.py	81.25% <0%> (ø)	⬆️
synapse/handlers/federation.py	61.72% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7039ece...44dc4c3. Read the comment docs.

[richvdh]

Yup so this lgtm. I've added a few notes below for future reference but none of them are big enough concerns for me to hold this back.

[richvdh]

It's not always necessary to bump this - you can just keep adding more delta files into the current delta directory.

[richvdh]

New Vector didn't write it, so this isn't really true.

You wrote it (all six words of it), so it's copyright yourself (with a license for us to use it via the DCO), either implicitly or explicitly. So either: Copyright 2018 Aaron Raimist, or just omit it.

[richvdh]

It would be useful to have a comment here explaining why this is a useful thing to do and some of the history

[richvdh]

(thanks!)