This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make Prometheus snippet less confusing on the metrics collection page #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Polonkai <gergely@polonkai.eu>
richvdh
approved these changes
Dec 11, 2018
|
Thanks. Please can you fill in a changelog entry. Please can you also make PRs against develop in future. (both are mentioned in CONTRIBUTING.rst and the PR template) |
Codecov Report
@@ Coverage Diff @@
## develop #4288 +/- ##
===========================================
- Coverage 73.49% 72.51% -0.98%
===========================================
Files 302 333 +31
Lines 29892 33883 +3991
Branches 4887 0 -4887
===========================================
+ Hits 21968 24570 +2602
- Misses 6488 9313 +2825
+ Partials 1436 0 -1436
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #4288 +/- ##
===========================================
- Coverage 73.49% 72.51% -0.98%
===========================================
Files 302 333 +31
Lines 29892 33883 +3991
Branches 4887 0 -4887
===========================================
+ Hits 21968 24570 +2602
- Misses 6488 9313 +2825
+ Partials 1436 0 -1436
Continue to review full report at Codecov.
|
|
I guess it's just docs. |
anoadragon453
added a commit
that referenced
this pull request
May 10, 2019
* develop: (45 commits) URL preview blacklisting fixes (#5155) Revert 085ae34 Add a DUMMY stage to captcha-only registration flow Make Prometheus snippet less confusing on the metrics collection doc (#4288) Set syslog identifiers in systemd units (#5023) Run Black on the tests again (#5170) Add AllowEncodedSlashes to apache (#5068) remove instructions for jessie installation (#5164) Run `black` on per_destination_queue Limit the number of EDUs in transactions to 100 as expected by receiver (#5138) Fix bogus imports in tests (#5154) add options to require an access_token to GET /profile and /publicRooms on CS API (#5083) Do checks on aliases for incoming m.room.aliases events (#5128) Remove the requirement to authenticate for /admin/server_version. (#5122) Fix spelling in server notices admin API docs (#5142) Fix sample config 0.99.3.2 include disco in deb build target list changelog Debian: we now need libpq-dev. ...
anoadragon453
added a commit
that referenced
this pull request
May 10, 2019
* develop: Revert 085ae34 Add a DUMMY stage to captcha-only registration flow Make Prometheus snippet less confusing on the metrics collection doc (#4288) Set syslog identifiers in systemd units (#5023) Run Black on the tests again (#5170) Add AllowEncodedSlashes to apache (#5068) remove instructions for jessie installation (#5164) Run `black` on per_destination_queue Limit the number of EDUs in transactions to 100 as expected by receiver (#5138)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port number used in the example is completely different from what is used in the synapse config snippets.
Signed-off-by: Gergely Polonkai gergely@polonkai.eu