This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enable ACME support in the docker image #4566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #4548 I hope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits
Codecov Report
@@ Coverage Diff @@
## release-v0.99.0 #4566 +/- ##
===================================================
- Coverage 74.91% 74.45% -0.46%
===================================================
Files 338 338
Lines 34495 35093 +598
Branches 5619 5789 +170
===================================================
+ Hits 25841 26130 +289
- Misses 7071 7351 +280
- Partials 1583 1612 +29 |
Co-Authored-By: richvdh <1389908+richvdh@users.noreply.github.com>
Co-Authored-By: richvdh <1389908+richvdh@users.noreply.github.com>
Co-Authored-By: richvdh <1389908+richvdh@users.noreply.github.com>
anoadragon453
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: