Use static locations for Riot icons

[turt2live]

See element-hq/element-web#9009

Requires riot.im changes - see timeline Deployed

[richvdh]

Again, looks plausible, but I'd like to know why we aren't going to have the same problem again.

[turt2live]

I'd like to know why we aren't going to have the same problem again.

Up until this, riot-web and other random uploads in random directories on several domains were responsible for the various avatars. Instead of hoping that things don't change and aren't forgotten (one of the logos I replaced was a Vector logo), we now have the icons in a central place in version control in a dedicated directory. The risk at this point is forgetting to update the assets, but that's better than accidentally deleting something that another thing was using.

[richvdh]

we now have the icons in a central place in version control in a dedicated directory.

ok, this certainly sounds like a sensible improvement. is there any scope for a README or something in that directory that reminds people that the URLs are used in notification emails, so to avoid breaking them if possible?

[turt2live]

Yup, already included :)

The images contained here are used by email notifications and such - do not rename or delete them without replacing all their references in other projects (sydent, synapse, etc).

(see the riot.im PR referenced in the timeline earlier up)

[richvdh]

\o/