This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Ratelimit 3pid invites #5104
Merged
Ratelimit 3pid invites #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do ratelimit sending the 3PID invite events, but that happens after spamming the identity server.
babolivier
reviewed
Apr 26, 2019
…telimit_3pid_invite
Codecov Report
@@ Coverage Diff @@
## develop #5104 +/- ##
===========================================
+ Coverage 61.67% 61.68% +<.01%
===========================================
Files 334 334
Lines 34514 34517 +3
Branches 5681 5681
===========================================
+ Hits 21288 21291 +3
Misses 11696 11696
Partials 1530 1530 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do ratelimit sending the 3PID invite events, but that happens after
spamming the identity server.