Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Switch Dockerfile to python 3 #5132

Closed
wants to merge 3 commits into from

Conversation

ordinarygulp
Copy link

@ordinarygulp ordinarygulp commented May 3, 2019

per blog: "We plan on ending mainstream support on 1st April 2019, where upon Python 3.5+ will be the only officially supported platform"
https://matrix.org/blog/2018/12/21/porting-synapse-to-python-3/

d2dyno added 2 commits May 3, 2019 03:31
per blog: "We plan on ending mainstream support on 1st April 2019, where upon Python 3.5+ will be the only officially supported platform"
https://matrix.org/blog/2018/12/21/porting-synapse-to-python-3/
@Half-Shot Half-Shot changed the title Switch to python 3 Switch Dockerfile to python 3 May 3, 2019
@Half-Shot
Copy link
Collaborator

(edited title to reflect that this is a docker PR)

@ordinarygulp
Copy link
Author

Thanks!

I tested this on my local installation (https://hub.docker.com/r/d2dyno/synapse-python3), and thus far have only encountered one minor notice:
/usr/local/lib/python3.7/site-packages/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.25.2) or chardet (3.0.4) doesn't match a supported version! RequestsDependencyWarning)

@anoadragon453
Copy link
Member

@d2dyno We're aware of the urllib3 issue and should be unrelated to this PR specifically.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly object to this change, but just so we're all clear:

the PYTHON_VERSION defined in the file just defines the default python version to build with. you can choose whichever version you prefer as documented in the comment at the top of the file.

Note that the default docker images distributed at https://hub.docker.com/r/matrixdotorg/synapse use 3.6.

@@ -0,0 +1 @@
Docker container now builds with Python 3.7.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Docker container now builds with Python 3.7.
Docker image now uses Python 3.7 by default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest making this a misc file rather than a feature. It's unlikely to affect the vast majority of regular users.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #5132 into develop will decrease coverage by 1.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #5132      +/-   ##
===========================================
- Coverage    61.69%   60.43%   -1.27%     
===========================================
  Files          336      328       -8     
  Lines        34549    34093     -456     
  Branches      5674     5627      -47     
===========================================
- Hits         21316    20605     -711     
- Misses       11702    12017     +315     
+ Partials      1531     1471      -60

@hawkowl
Copy link
Contributor

hawkowl commented Jun 25, 2019

Fixed by way of #5546, which sets it to be the default to be built and sent to Docker Hub as well.

@hawkowl hawkowl closed this Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants