This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Neilj/ensure get profileinfo available in client reader slaved store #5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5213 +/- ##
===========================================
- Coverage 62.48% 62.15% -0.33%
===========================================
Files 338 336 -2
Lines 35035 34716 -319
Branches 5734 5690 -44
===========================================
- Hits 21890 21578 -312
- Misses 11596 11602 +6
+ Partials 1549 1536 -13 |
|
I ran this locally with workers and it started up |
erikjohnston
approved these changes
May 21, 2019
neilisfragile
deleted the
neilj/ensure-get_profileinfo-available-in-ClientReaderSlavedStore
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediation of #5200