This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Share an SSL context object between SSL connections #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves changing how the info callbacks work.
turns out we need a shiny version of service_identity to enforce this correctly.
Add some tests for bad certificates for federation and .well-known connections
erikjohnston
approved these changes
Jun 10, 2019
synapse/crypto/context_factory.py
Outdated
| # ... and we also gut-wrench a 'tls_verifier' attribute into the | ||
| # tls_protocol so that the SSL context's info callback has something to | ||
| # call to do the cert verification. | ||
| setattr(tls_protocol, "tls_verifier", self._verifier) |
There was a problem hiding this comment.
Looking at the Twisted code it looks somewhat like nothing else actually uses the app data, so I wonder if we can avoid the gut wrenching here.
But since we are gut wrenching can we name space this so that we don't accidentally collide with a param in twisted, e.g. _synapse_tls_verifier?
There was a problem hiding this comment.
Looking at the Twisted code it looks somewhat like nothing else actually uses the app data, so I wonder if we can avoid the gut wrenching here.
that didn't seem like an assumption I particularly wanted to make.
But since we are gut wrenching can we name space this so that we don't accidentally collide with a param in twisted, e.g. _synapse_tls_verifier?
fair
|
This has fixed: #5395 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes massive memory use with
federation_verify_certificates: true,by sharing a couple of openssl context objects between all connections.
This involves changing how the info callbacks work and is generally a bit of a
rewrite of the context_factory stuff.
Also fixes a bug where connections to IP literal homeservers would always fail.