Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Send 3PID bind requests as JSON data #5658

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Send 3PID bind requests as JSON data #5658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f77e997
Send 3PID bind requests as JSON data
babolivier Jul 10, 2019
351d9bd
Rename changelog file
babolivier Jul 10, 2019
b2a2e96
Typo
babolivier Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5658.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix 3PID bind requests being sent to identity servers as `application/x-form-www-urlencoded` data, which is deprecated.
2 changes: 1 addition & 1 deletion synapse/handlers/identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def bind_threepid(self, creds, mxid):
raise SynapseError(400, "No client_secret in creds")

try:
data = yield self.http_client.post_urlencoded_get_json(
data = yield self.http_client.post_json_get_json(
"https://%s%s" % (id_server, "/_matrix/identity/api/v1/3pid/bind"),
{"sid": creds["sid"], "client_secret": client_secret, "mxid": mxid},
)
Expand Down