Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow HS to send emails when adding an email to the HS #6042

Merged
merged 47 commits into from
Sep 20, 2019
Merged

Allow HS to send emails when adding an email to the HS #6042

merged 47 commits into from
Sep 20, 2019

Commits on Sep 16, 2019

  1. Allow HS to send emails when adding an email to the HS

    @anoadragon453
    anoadragon453 committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    0e5d92d View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @anoadragon453
    anoadragon453 committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    92b3246 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Add changelog

    @anoadragon453
    anoadragon453 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    626ebbd View commit details
    Browse the repository at this point in the history

  2. Add 'add threepid' email templates to config. Gen sample config

    @anoadragon453
    anoadragon453 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    8132107 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into anoa/account_3pid_homeserver

    @anoadragon453
    anoadragon453 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    d309ea2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'anoa/account_3pid_homeserver' into anoa/account_3pid_ho… 

    …meserver_send_email
    @anoadragon453
    anoadragon453 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    112d55e View commit details
    Browse the repository at this point in the history

  5. Add 3PID bind sytests to blacklist temporarily

    @anoadragon453
    anoadragon453 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    096808b View commit details
    Browse the repository at this point in the history

  6. Prevent /account/3pid from binding to an identity server

    @anoadragon453
    anoadragon453 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    268bbbb View commit details
    Browse the repository at this point in the history

  7. Correct some small issues and fix bug 

    There was a bug in how validate_threepid_session was called when POST'ing to
the password reset endpoint. It thought the method returned a boolean to check
if a validation was incorrect, but instead it raises an exception. This has
been corrected
    @anoadragon453
    anoadragon453 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    dda5137 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Address review comments

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    8e2481b View commit details
    Browse the repository at this point in the history

  2. Remove the requirement for a medium argument

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    f6c0d5c View commit details
    Browse the repository at this point in the history

  3. Handle the homeserver disabling email validation

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    923736f View commit details
    Browse the repository at this point in the history

  4. Remove blacklist

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    4fc7796 View commit details
    Browse the repository at this point in the history

  5. Fix add_threepid template default values in emailconfig

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    15bf108 View commit details
    Browse the repository at this point in the history

  6. Remove redundant logging

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    d20feec View commit details
    Browse the repository at this point in the history

  7. Undo fix on password reset POST submit_token endpoint

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    0e5c7bf View commit details
    Browse the repository at this point in the history

  8. Update synapse/storage/registration.py 

    Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @anoadragon453 @richvdh
    anoadragon453 and richvdh authored Sep 18, 2019
    Configuration menu
    Copy the full SHA
    46da943 View commit details
    Browse the repository at this point in the history

  9. Use an assert instead of if-statement with SynapseError

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    3941439 View commit details
    Browse the repository at this point in the history

  10. Remove trailing slashes from submit_token endpoint patterns

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    0200e41 View commit details
    Browse the repository at this point in the history

  11. python3 super()

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    c8dbf53 View commit details
    Browse the repository at this point in the history

  12. Remove self.hs set from AddThreepidSubmitTokenServlet

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    d32724b View commit details
    Browse the repository at this point in the history

  13. Clarify changelog

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    0812664 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'anoa/account_3pid_homeserver_send_email' of github.com:… 

    …matrix-org/synapse into anoa/account_3pid_homeserver_send_email
    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    9309ca5 View commit details
    Browse the repository at this point in the history

  15. Sanity check ThreepidBehaviour.REMOTE on submit_token endpoint

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    46e6d92 View commit details
    Browse the repository at this point in the history

  16. Re-blacklist tests

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b37d71c View commit details
    Browse the repository at this point in the history

  17. Factor out removing id_server from msisdn

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    16eb35d View commit details
    Browse the repository at this point in the history

  18. Remove POST /add_threepid/<medium>/submit_token

    @anoadragon453
    anoadragon453 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    16d7ec2 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Ensure REMOTE vs LOCAL ThreepidBehaviour is handled

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    ab1ae2f View commit details
    Browse the repository at this point in the history

  2. URL encode validation link parameters

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    1be82f8 View commit details
    Browse the repository at this point in the history

  3. Move jinja failure template loading into servlet constructor

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    317332e View commit details
    Browse the repository at this point in the history

  4. Make add_threepid submit_token email-only

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    59e0aad View commit details
    Browse the repository at this point in the history

  5. Make get_threepid_validation_session require client_secret

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    882642e View commit details
    Browse the repository at this point in the history

  6. Update changelog entry

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    1464f14 View commit details
    Browse the repository at this point in the history

  7. Set email

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    fb9c582 View commit details
    Browse the repository at this point in the history

  8. Make sure templates only get loaded when necessary

    @anoadragon453
    anoadragon453 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    f62ddf6 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Remove unnecessary vars and params

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    0dcdfbb View commit details
    Browse the repository at this point in the history

  2. Ensure link is not a tuple

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    d683ae5 View commit details
    Browse the repository at this point in the history

  3. Pull if validation_session out of helper method

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    f62a27c View commit details
    Browse the repository at this point in the history

  4. this confused me for so long

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    ac92a58 View commit details
    Browse the repository at this point in the history

  5. Don't force https on account_threepid_delegates

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    38a543c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' of github.com:matrix-org/synapse into anoa/acc… 

    …ount_3pid_homeserver_send_email
    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    2f296c7 View commit details
    Browse the repository at this point in the history

  7. Ensure we catch HttpResponseException when calling to id servers

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    b12e51a View commit details
    Browse the repository at this point in the history

  8. Unpack response from identity server to check for errors

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    1267abd View commit details
    Browse the repository at this point in the history

  9. Remove prefix nonsense

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    b3bf430 View commit details
    Browse the repository at this point in the history

  10. Factor out password_reset trailing slash change

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    227ec33 View commit details
    Browse the repository at this point in the history

  11. Address review comments

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    4efc108 View commit details
    Browse the repository at this point in the history

  12. validation_session cannot be None

    @anoadragon453
    anoadragon453 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    7c351df View commit details
    Browse the repository at this point in the history