This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Disable bytes usage with postgres #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More often than not passing bytes to `txn.execute` is a bug (where we meant to pass a string) that just happens to work if `BYTEA_OUTPUT` is set to `ESCAPE`. However, this is a bit of a footgun so we want to instead error when this happens, and force using `bytearray` if we actually want to use bytes.
erikjohnston
force-pushed
the
erikj/disable_sql_bytes
branch
from
75b53a6
to
1d38583
Compare
erikjohnston
force-pushed
the
erikj/disable_sql_bytes
branch
2 times, most recently
from
763f430
to
c3b34dc
Compare
This was referenced Jan 14, 2021
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More often than not passing bytes to
txn.executeis a bug (where wemeant to pass a string) that just happens to work if
BYTEA_OUTPUTisset to
ESCAPE. However, this is a bit of a footgun so we want toinstead error when this happens, and force using
bytearrayif weactually want to use bytes.
Based on #6185