Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Split out state storage into separate data store. #6245

Closed
wants to merge 4 commits into from

Conversation

erikjohnston
Copy link
Member

This also includes splitting purge storage APIs into two, one that works on events and the other on state.

Based on #6240.

Commits independently reviewable.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these multi-thousand-line diffs are a bit unreviewable. Is there any way to split them up so that code moves are separate from changes?

@@ -39,12 +40,15 @@ class Storage(object):
"""

def __init__(self, hs, stores: DataStores):
self.stores = stores
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

# We include the main data store here mainly so that we don't have to
# rewrite all the existing code to split it into high vs low level
# interfaces.
self.main = stores.main

self.persistence = EventsPersistenceStore(hs, stores)
self.state = StateGroupStorage(hs, stores)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #6240 (comment): the inconsistency in naming between Storage and Store is... inconsistent.

@erikjohnston
Copy link
Member Author

Fair, I've tried to keep the massive diffs in separate commits, but let me see if I can rejig these a bit further

@erikjohnston erikjohnston force-pushed the erikj/split_out_state_store branch from a03c7f9 to 2ddefcd Compare October 30, 2019 14:03
@erikjohnston
Copy link
Member Author

Ok, I'm splitting this up some more into separate PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants