Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix /keys/query API on workers. #6256

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Conversation

erikjohnston
Copy link
Member

The necessary getters were added only to the master store and not the
worker stores.

The necessary getters were added only to the master store and not the
worker stores.
@erikjohnston
Copy link
Member Author

I think this was broke in #5769

@erikjohnston erikjohnston requested a review from a team October 25, 2019 10:12
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plausible

@richvdh
Copy link
Member

richvdh commented Oct 25, 2019

shame this wasn't picked up in any tests

@erikjohnston
Copy link
Member Author

I'm updating the worker routes on sytest to match those in docs/workers.rs, which should hopefully pick this up

@erikjohnston erikjohnston merged commit 67290fa into release-v1.5.0 Oct 25, 2019
@erikjohnston
Copy link
Member Author

matrix-org/sytest#732 hopefully tests this

richvdh added a commit that referenced this pull request Oct 28, 2019
Synapse 1.5.0rc2 (2019-10-28)
=============================

Bugfixes
--------

- Update list of boolean columns in `synapse_port_db`. ([\#6247](#6247))
- Fix /keys/query API on workers. ([\#6256](#6256))
- Improve signature checking on some federation APIs. ([\#6262](#6262))

Internal Changes
----------------

- Move schema delta files to the correct data store. ([\#6248](#6248))
- Small performance improvement by removing repeated config lookups in room stats calculation. ([\#6255](#6255))
@erikjohnston erikjohnston deleted the erikj/fix_e2e_workers branch January 9, 2020 15:47
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '67290fa03':
  Newsfile
  Fix /keys/query API on workers.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants