This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
fix delete_existing for _persist_events #6300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is part of _retry_on_integrity_error, so should only be on _persist_events_and_state_updates
richvdh
commented
Oct 30, 2019
| @@ -82,7 +82,7 @@ def _retry_on_integrity_error(func): | |||
| @defer.inlineCallbacks | |||
| def f(self, *args, **kwargs): | |||
| try: | |||
| res = yield func(self, *args, **kwargs) | |||
| res = yield func(self, *args, delete_existing=False, **kwargs) | |||
There was a problem hiding this comment.
this is just to make it more obvious next time we mess it up (the bug only manifests on IntegrityErrors currently)
erikjohnston
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part of _retry_on_integrity_error, so should only be on _persist_events_and_state_updates