Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix /purge_room admin API #6307

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Fix /purge_room admin API #6307

merged 3 commits into from
Oct 31, 2019

Conversation

erikjohnston
Copy link
Member

Presumably broken since #6115

It fails trying to clean the `topic` table which was recently removed.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 69489f8 into develop Oct 31, 2019
@rubo77
Copy link
Contributor

rubo77 commented Nov 20, 2019

So what were the consequences of this bug?

Since what version was it introduced?

@richvdh
Copy link
Member

richvdh commented Nov 21, 2019

So what were the consequences of this bug?

the purge_room api didn't work

Since what version was it introduced?

as per the description

@rubo77
Copy link
Contributor

rubo77 commented Nov 21, 2019

#6115 was merged 30.9.2019 in 16cb9a7 on develop and mergid into v1.5.0: https://github.com/matrix-org/synapse/releases/tag/v1.5.0

so if you are on 1.5.0 and need the purge-api, hurry up updating ;)

@richvdh
Copy link
Member

richvdh commented Nov 21, 2019

to be clear, purge_room != purge_history.

@erikjohnston erikjohnston deleted the erikj/fix_purge_room branch January 9, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants