This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add published room list edit API #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2016
| @@ -317,3 +317,19 @@ def _user_can_delete_alias(self, alias, user_id): | |||
|
|
|||
| is_admin = yield self.auth.is_server_admin(UserID.from_string(user_id)) | |||
| defer.returnValue(is_admin) | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def edit_published_room_list(self, requester, room_id, visibility): | |||
There was a problem hiding this comment.
maybe add some doc string
|
Code LGTM. Some sytests would be nice. ["published", "unpublished"] or ["published", "hidden"] might be better words than ["public", "private"]. |
That's on the radar
Unpublished might be better than private, but the intent here is to allow various other values for the visibility, e.g. "local_server" or whatever, so I don't think "published" really conveys what's going on. |
erikjohnston
added a commit
that referenced
this pull request
Mar 22, 2016
Add published room list edit API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.