Admin api to add an email address

synapse/handlers/auth.py

@@ -816,6 +816,14 @@ def delete_access_tokens_for_user(
 
     @defer.inlineCallbacks
     def add_threepid(self, user_id, medium, address, validated_at):
+        # check if medium has a valid value
+        if medium not in ["email", "msisdn"]:
+            raise SynapseError(
+                code=400,
+                msg=("'%s' is not a valid value for 'medium'" % (medium)),
+                errcode=Codes.INVALID_PARAM,
+            )
+
         # 'Canonicalise' email addresses down to lower case.
         # We've now moving towards the homeserver being the entity that
         # is responsible for validating threepids used for resetting passwords

synapse/rest/admin/users.py

@@ -174,6 +174,10 @@ async def on_PUT(self, request, user_id):
                 )
 
             if "threepids" in body:
+                # check for required parameters for each threepid
+                for threepid in body["threepids"]:
+                    assert_params_in_dict(threepid, ["medium", "address"])
+
                 # remove old threepids from user
                 threepids = await self.store.user_get_threepids(user_id)
                 for threepid in threepids:
@@ -257,6 +261,10 @@ async def on_PUT(self, request, user_id):
             )
 
             if "threepids" in body:
+                # check for required parameters for each threepid
+                for threepid in body["threepids"]:
+                    assert_params_in_dict(threepid, ["medium", "address"])
+
                 current_time = self.hs.get_clock().time_msec()
                 for threepid in body["threepids"]:
                     await self.auth_handler.add_threepid(

tests/rest/admin/test_user.py

@@ -478,8 +478,6 @@ def test_requester_is_admin(self):
         self.assertEqual("foobar", channel.json_body["displayname"])
         self.assertEqual(True, channel.json_body["deactivated"])
         # the user is deactivated, the threepid will be deleted
-        # self.assertEqual("email", channel.json_body["threepids"][0]["medium"])
-        # self.assertEqual("bob2@bob.bob", channel.json_body["threepids"][0]["address"])
 
         # Get user
         request, channel = self.make_request(