This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Clean up replication unit tests. #7490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
commented
May 13, 2020
| USER_ID = "@feeling:blue" | ||
| USER_ID_2 = "@bright:blue" | ||
| USER_ID = "@feeling:test" | ||
| USER_ID_2 = "@bright:test" |
There was a problem hiding this comment.
This is the correct server name used by the test HS objects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly makes
tests.replication.slavetests use the same base class astests.replication.tcp, so that we can remove the various gut wrenching that takes place intests.replication.slaveand instead properly spawn two separate HS objects like we do for thetcptests.