This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Enable 3PID add/bind/unbind endpoints on r0 routes #7685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Jun 12, 2020
|
It seems we assumed (at least on web) that these would be r0 once the server supports r0.6.0 in versions. |
well that's good in a way, but also bad if it means that 1.15 has broken adding 3pids... |
With a quick test on matrix.org, it does indeed mean that: 3PID adding fails because we now try r0, since the server advertises r0.6.0. 😖 |
|
Darn, looks like we missed checking the right routes were advertised during #6585. |
richvdh
previously requested changes
Jun 15, 2020
richvdh
reviewed
Jun 15, 2020
richvdh
approved these changes
Jun 15, 2020
babolivier
force-pushed
the
babolivier/3pid_r0
branch
2 times, most recently
from
010c0d2
to
90821c1
Compare
babolivier
force-pushed
the
babolivier/3pid_r0
branch
from
90821c1
to
6d5985e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like these endpoints made it to the r0 CS API but we never enabled them on the /r0 route.