Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix a typo when comparing the URI & method during UI Auth. #7689

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Fix a typo when comparing the URI & method during UI Auth. #7689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7689.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Compare the URI and method during user interactive authentication (instead of the URI twice). Bug introduced in 1.13.0rc1.
2 changes: 1 addition & 1 deletion synapse/handlers/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ async def check_auth(

# Convert the URI and method to strings.
uri = request.uri.decode("utf-8")
method = request.uri.decode("utf-8")
method = request.method.decode("utf-8")

# If there's no session ID, create a new session.
if not sid:
Expand Down