Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix "argument of type 'ObservableDeferred' is not iterable" error #7708

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Jun 16, 2020

Fixes #3234

Per the comment in the file this is an ObservableDeferred not a Deferred and since the former is not a subclass of the latter then the type check is not working.

I believe I've adapted the code OK, but I'm not really sure how to test this.

@clokep clokep changed the title Fix for ObserverableDeferred vs. Deferred differences in receipts store. Fix for ObservableDeferred vs. Deferred differences in receipts store. Jun 16, 2020
@clokep clokep changed the title Fix for ObservableDeferred vs. Deferred differences in receipts store. Fix "argument of type 'ObservableDeferred' is not iterable" error Jun 16, 2020
@clokep clokep requested a review from a team June 16, 2020 14:24
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks about right

@clokep clokep merged commit 2312525 into develop Jun 16, 2020
@clokep clokep deleted the clokep/obs-def-fix branch June 16, 2020 16:01
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '231252516':
  Fix "argument of type 'ObservableDeferred' is not iterable" error (#7708)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to handle EDU of type 'm.receipt': argument of type 'ObservableDeferred' is not iterable
2 participants