Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Ensure that event.redacts exists before handling it as a string #8457

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Ensure that event.redacts exists before handling it as a string #8457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfb32b2
Handle event.redacts being None.
clokep Oct 2, 2020
412ba51
Apply suggestions from code review.
clokep Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8457.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug where backfilling a room with an event that was missing the `redacts` field would break.
2 changes: 2 additions & 0 deletions synapse/event_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,8 @@ def check_redaction(

if room_version_obj.event_format == EventFormatVersions.V1:
redacter_domain = get_domain_from_id(event.event_id)
if not isinstance(event.redacts, str):
return False
redactee_domain = get_domain_from_id(event.redacts)
if redacter_domain == redactee_domain:
return True
Expand Down