This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Abstract shared SSO code #8765
Merged
Merged
Abstract shared SSO code #8765
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e40bcf8
Inherit from BaseHandler.
clokep 5ad5b73
Abstract rendering errors.
clokep 9f849b7
Abstract getting by remote user ID.
clokep 713b590
Add a newsfragment.
clokep 49290da
Add some more type hints.
clokep c013c83
Fix comment from review.
clokep 9f3f657
Rename a variable.
clokep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I question whether these need to be at
info
level.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it is at info since a server admin might get a report "I can't login via SSO" or something and want to have some logs about what is happening.
(Note that this is also just copied, I didn't change the log level.)
I don't have a strong opinion on this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point.
Yeah, just questioning it as a drive-by. I have an idea for improvement, but I can drop these changes in a separate PR if you think they make sense:
Perhaps we could ditch/drop down the level of the "Looking" log line, and keep (and extend with more info) the "Found existing mapping" line for when users do have problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might work? I think it makes sense as a separate PR since that isn't really abstracting. 😄