Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Strip trailing / from server_url in register_new_matrix_user #8823

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Strip trailing / from server_url in register_new_matrix_user #8823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb1464
Strip trailing / from server_url in register_new_matrix_user
angdraug Nov 25, 2020
061bbb2
Update 8823.bugfix
richvdh Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8823.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix `register_new_matrix_user` failing with "Bad Request" when trailing slash is included in server URL. Contributed by @angdraug.
2 changes: 1 addition & 1 deletion synapse/_scripts/register_new_matrix_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def request_registration(
exit=sys.exit,
):

url = "%s/_synapse/admin/v1/register" % (server_location,)
url = "%s/_synapse/admin/v1/register" % (server_location.rstrip("/"),)

# Get the nonce
r = requests.get(url, verify=False)
Expand Down