Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean up ShardedWorkerHandlingConfig #9466

Merged
merged 5 commits into from
Feb 24, 2021
Merged

Commits on Feb 22, 2021

  1. Split ShardedWorkerHandlingConfig

    This is so that we have a type level understanding of when it is safe to
    call `get_instance(..)` (as opposed to `should_handle(..)`).
    erikjohnston committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    931b9a9 View commit details
    Browse the repository at this point in the history
  2. Remove special cases in ShardedWorkerHandlingConfig.

    `ShardedWorkerHandlingConfig` tried to handle the various different ways
    it was possible to configure federation senders and pushers. This led to
    special cases that weren't hit during testing.
    
    To fix this the handling of the different cases is moved from there and
    `generic_worker` into the worker config class. This allows us to have
    the logic in one place and allows the rest of the code to ignore the
    different cases.
    erikjohnston committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    6b93ad3 View commit details
    Browse the repository at this point in the history
  3. Newsfile

    erikjohnston committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    35b8416 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Check 'self.writers.events' is non-empty, and raise more helpful erro…

    …r in RoutableShardedWorkerHandlingConfig
    erikjohnston committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    13af8a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Fix up comments/errors

    erikjohnston committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    173c79e View commit details
    Browse the repository at this point in the history